Provide reasonable fallback for event target when mouse position exits viewport #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Prevents unhandled exception “Not a valid Node” when the container that holds the draggables sits flush against the edge of the viewport, and the user moves their mouse cursor outside the bounds of the visible viewport while dragging.
|
Thank you @aaronlademann-wf for this fix. I will merge it and release a new version on pub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the "container" that holds the draggables sits flush against the edge of the viewport, and the user moves their mouse cursor outside the bounds of the visible viewport while dragging, an unhandled exception is thrown (see screen capture below).
These changes make it so that a valid
EventTargetis provided at all times within_getRealTarget.For your approval @marcojakob
cc/ @greglittlefield-wf @clairesarsam-wf @jacehensley-wf @joelleibow-wf